Skip to content

fix fypp_deployment build and set maxrank default to 4 as in cmake #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix fypp_deployment build and set maxrank default to 4 as in cmake #882

merged 1 commit into from
Oct 25, 2024

Conversation

jalvesz
Copy link
Contributor

@jalvesz jalvesz commented Oct 19, 2024 •
edited
Loading

Small fix for the build option in the fypp_deployment script and change default maxrank. The previous command line construc worked in Linux but was not working on windows.

jvdp1
jvdp1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jalvesz

perazz
perazz approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see no issues with it. Thanks @jalvesz

@jvdp1 jvdp1 merged commit 8672fe1 into fortran-lang:master Oct 25, 2024
16 checks passed
@jalvesz jalvesz deleted the fypp_deployment branch October 26, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perazz perazz perazz approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalvesz @perazz @jvdp1